I've submitted patch that should remove this regression
On Wed, Apr 3, 2013 at 6:55 PM, Alexey Pelykh <alexey.pelykh@xxxxxxxxx> wrote:
> Paul,
>
> Should I start a new email chain with that patch or add it here?
>
> On Wed, Apr 3, 2013 at 12:19 AM, Alexey Pelykh <alexey.pelykh@xxxxxxxxx> wrote:
>> Hi Paul,
>>
>> No problem, I'll prepare patch in next 24 hours and will send in ASAP.
>>
>> But, since we've found the issue, I suggest that we should look at it
>> closer, especially since at this moment only you can reproduce it. As
>> far as I understand, but I may be wrong,
>> this comment is wrong, since if to specify
>> OMAP_UART_SCR_RX_TRIG_GRANU1_MASK, it effectively sets Rx threshold to
>> 1 character, instead of 16.
>> /* Set receive FIFO threshold to 16 characters and
>> * transmit FIFO threshold to 16 spaces
>> */
>>
>> On Tue, Apr 2, 2013 at 9:24 PM, Paul Walmsley <paul@xxxxxxxxx> wrote:
>>> On Mon, 1 Apr 2013, Alexey Pelykh wrote:
>>>
>>>> Paul, can you please try to comment out change related to Rx line
>>>> (granulation one). That's only Rx line related change in the patch.
>>>
>>> Yes, looks like simply reverting the commit 1776fd059c40 ("OMAP/serial:
>>> Fix incorrect Rx FIFO threshold setting, LSR validation on Tx, and Tx FIFO
>>> IRQ generation") change to OMAP_UART_SCR_RX_TRIG_GRANU1_MASK fixes it.
>>>
>>> Care to send a patch doing so ASAP for v3.9-rc fixes? That would moot the
>>> revert of the entire commit 1776fd059c40.
>>>
>>>
>>> - Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
