On Thursday 28 March 2013 02:19 AM, Tony Lindgren wrote: > * Santosh Shilimkar <santosh.shilimkar@xxxxxx> [130327 13:52]: >> On Thursday 28 March 2013 12:11 AM, Kevin Hilman wrote: >>> Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: >>> >>>> From: Tero Kristo <t-kristo@xxxxxx> >>>> >>>> Simplifies code and also allows the re-use as is on OMAP5 devices. >>> >>> nit: changelog here is rather weak. It claims "simplifies code" but >>> it's not obvious from the patch how changing a few #defines does that. >>> >> I agree. Basically the offset are chosen such a way that they can >> work on OMAP4 and OMAP5 instead of having two separate sets. >> Will expand the changelog to make it clear. > > You might want to mention also that the offsets are only used by > the kernel to save and restore registers from so people don't > think those are hardare registers and that the patch might break > some things. > Yeah. Will mention that. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
