On 2013-03-21 08:14, Archit Taneja wrote: > On Wednesday 20 March 2013 08:58 PM, Tomi Valkeinen wrote: >> On 2013-03-20 17:17, Archit Taneja wrote: >>> On Friday 08 March 2013 05:22 PM, Tomi Valkeinen wrote: >>>> + if (dss.dpll4_m4_ck == NULL) { >>>> + /* XXX can we change the clock on omap2? */ >>> >>> We can change dss_fclk1 on omap2, and the cclock2420_data.c and >>> cclock2430_data.c have clksel structs which allow a set of dividers. The >>> dividers are not continuous though, 1 to 12 and 16 are allowed. So we >>> might need to change the code here a bit, if we want to change the clock >>> in the first place. >> >> Ok, good to know. Note that the comment is copied from the old code. I >> think I tried changing the clock on N800 with clk_set_rate long ago, but >> I didn't get it to work. Things might have changed, but, well, I don't >> think we should spend time on omap2 code. I'm sure we'll get a patch if >> somebody needs it =). > > We could change the comment to a TODO for now. Yep, not a bad idea. I'll make the change. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature