On Mon, Mar 11, 2013 at 3:51 AM, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote: > On 03/11/2013 09:58 AM, Roger Quadros wrote: > > IMHO the 'hack' in the twl-regulator should not have been removed before we > provide proper support for the clocks via the common clock framework. > I was surprised that this happened in the first place, but I guess it really wasn't obvious that it was still in use. > > We should have the clock driver under drivers/clk/ via clk-twl6030.c driver > for all the clocks twl6030 provides and use that in drivers (updating the > clock tree as well). > I spent some more time looking at clk-twl6030.c, and it seems it just turns the twl6030 chip on when you ask it to enable the clock, and as far as I can tell that happens based on module dependencies? There aren't any explicit references to it that I can find, so I'm not entirely sure how a clk-twl6040 would cause a clock to be enabled. >>> If for whatever reason the commits cannot be reverted, would creating >>> a driver like drivers/clk/clk-twl6040.c that enabled the twl6030's >>> clock output be a suitable alternative? I'd be willing to take a stab >>> at writing it if there's not something like that in the works already. > > If you can take this it would be great. It is still in my to-do list to > integrate the clk-twl6040 clock with the omap-mcpdm driver. I already got > working code, but it is not working in a way I would really wanted to be. > Integrating external clock to the SoC's clock tree does not seams to be that > straight forward: at boot time when the clock tree is initialized the external > chip is yet to be probed -> the root clock is not there, but later on for some > reason I can not get the CCF to enable the clock tree correctly. I looked into the early boot clock setup code, and that does look a lot less straightforward. There are already a few 32k clocks listed there, and I *think* they all source from the twl6040; do they just come up automatically at power-on? >From what I can tell, clk32kg is just a gated fork of the regular 32k clock that is available at boot from twl6040. I am surprised it doesn't come on by default. I also don't have a TRM for twl6040 that matches up with what twl-regulator.c is doing to enable the clk32kg output; it looks like it's adding it to one of the power modes, but I'm not entirely sure how the registers it's writing to work, so my confidence level in being able to get it transplanted to a separate driver has lowered quite a bit. --- --Levi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
