On Tue, Mar 12, 2013 at 3:32 PM, kishon <kishon@xxxxxx> wrote: > Hi, > > > On Sunday 10 March 2013 06:37 AM, Grazvydas Ignotas wrote: >> >> In some rare cases we may get multiple interrupts that will generate >> duplicate omap_musb_mailbox() calls. This is a problem because each >> VBUS/ID event generates runtime_pm call in OMAP glue code, causing >> unbalanced gets or puts and breaking PM. > > > Did you actually observed multiple interrupts? Actually we thought > debouncing should be handled in hardware. I think I saw it a few times, although it might have been something else. In any case the software check is very cheap and there is no reason not to have it, IMO. > >> >> The same goes for initial state, glue already defaults to "no cable" >> state, so only bother it if we have VBUS or ID. >> >> Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx> > > Reviewed-by: Kishon Vijay Abraham I <kishon@xxxxxx> > > Thanks > Kishon -- Gražvydas -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
