On 03/08/2013 08:25 PM, Anil Kumar wrote: > Hi Jon, > > On Fri, Mar 8, 2013 at 10:57 PM, Jon Hunter <jon-hunter@xxxxxx> wrote: >> Adds basic device-tree support for OMAP3430 SDP board which has 256MB >> of RAM and uses the TWL4030 power management IC. > > I think this board support should be in separate patch series with > related patches. Well I wanted to keep them altogether so that I can send a pull request to Benoit and Tony. >> >> Signed-off-by: Jon Hunter <jon-hunter@xxxxxx> >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/omap3430-sdp.dts | 46 ++++++++++++++++++++++++++++++++++++ >> 2 files changed, 47 insertions(+) >> create mode 100644 arch/arm/boot/dts/omap3430-sdp.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 9c62558..89013ed 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -119,6 +119,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \ >> omap3-beagle-xm.dtb \ >> omap3-evm.dtb \ >> omap3-tobi.dtb \ >> + omap3430-sdp.dtb \ >> omap4-panda.dtb \ >> omap4-panda-a4.dtb \ >> omap4-panda-es.dtb \ >> diff --git a/arch/arm/boot/dts/omap3430-sdp.dts b/arch/arm/boot/dts/omap3430-sdp.dts >> new file mode 100644 >> index 0000000..be0650d >> --- /dev/null >> +++ b/arch/arm/boot/dts/omap3430-sdp.dts >> @@ -0,0 +1,46 @@ >> +/* >> + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/ >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> +/dts-v1/; >> + >> +/include/ "omap3.dtsi" >> + >> +/ { >> + model = "TI OMAP3430 SDP"; >> + compatible = "ti,omap3430-sdp", "ti,omap3"; > > I have not seen any related changes in "board-generic.c" for your board. > So just wanted know, how this board is booting ? If you look at board-generic.c you will see that "ti,omap3" will match the OMAP3 generic machine. So you don't need to modify the board-generic.c. >> + >> + memory { >> + device_type = "memory"; >> + reg = <0x80000000 0x10000000>; /* 256 MB */ >> + }; >> +}; >> + >> +&i2c1 { >> + clock-frequency = <2600000>; >> + >> + twl: twl@48 { >> + reg = <0x48>; >> + interrupts = <7>; /* SYS_NIRQ cascaded to intc */ >> + interrupt-parent = <&intc>; >> + }; >> +}; >> + >> +/include/ "twl4030.dtsi" >> + >> +&mmc1 { >> + vmmc-supply = <&vmmc1>; >> + vmmc_aux-supply = <&vsim>; >> + bus-width = <8>; >> +}; >> + >> +&mmc2 { >> + status = "disabled"; >> +}; >> + >> +&mmc3 { >> + status = "disabled"; >> +}; > > I think you should disable modules those are not currently used > as they are enabled by default in omap3.dtsi. > > exp:- > > &mcbsp2 { > status = "disabled"; > }; Well may be we could do that in a follow-up patch. If you look at other omap3 boards we have not gone through and disabled all unused modules either. So although I agree, right now I just want to get minimal support added. Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
