Re: [PATCH 1/1] gpio: omap: dts: Move interrupt-controller from #interrupt-cells description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/04/2013 12:35 PM, Javier Martinez Canillas wrote:
> The binding documentation for the OMAP GPIO controller has the description
> for the "#interrupt-cells" property after the "interrupt-controller"
> definition. This is confusing so is better to move "interrupt-controller"
> after the "#interrupt-cells" description.
> 
> Reported-by: Stephen Warren <swarren@xxxxxxxxxx>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/gpio/gpio-omap.txt         |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-omap.txt b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> index bff51a2..8b9914c 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-omap.txt
> @@ -10,7 +10,6 @@ Required properties:
>    - second cell is used to specify optional parameters (unused)
>  - gpio-controller : Marks the device node as a GPIO controller.
>  - #interrupt-cells : Should be 2.
> -- interrupt-controller: Mark the device node as an interrupt controller
>    The first cell is the GPIO number.
>    The second cell is used to specify flags:
>      bits[3:0] trigger type and level flags:
> @@ -18,6 +17,7 @@ Required properties:
>        2 = high-to-low edge triggered.
>        4 = active high level-sensitive.
>        8 = active low level-sensitive.
> +- interrupt-controller: Mark the device node as an interrupt controller.
>  
>  OMAP specific properties:
>  - ti,hwmods: Name of the hwmod associated to the GPIO:
> 

Thanks. Do you mind putting "interrupt-controller" before
"#interrupt-cells" as I see this is how they have it in
Documenation/devicetree/bindings/interrupt-controller/interrupts.txt?
Otherwise ...

Acked-by: Jon Hunter <jon-hunter@xxxxxx>

Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux