On 03/01/2013 03:25 PM, Ezequiel Garcia wrote:
> Hi Jon,
>
> On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter <jon-hunter@xxxxxx> wrote:
> [...]
>> +static int gpmc_probe_nor_child(struct platform_device *pdev,
>> + struct device_node *child)
>> +{
>> + struct gpmc_settings gpmc_s;
>> + struct gpmc_timings gpmc_t;
>> + struct resource res;
>> + unsigned long base;
>> + int ret, cs;
>> +
>> + if (of_property_read_u32(child, "reg", &cs) < 0) {
>> + dev_err(&pdev->dev, "%s has no 'reg' property\n",
>> + child->full_name);
>> + return -ENODEV;
>> + }
>> +
>> + if (of_address_to_resource(child, 0, &res)) {
>> + dev_err(&pdev->dev, "%s has malformed 'reg' property\n",
>> + child->full_name);
>> + return -ENODEV;
>> + }
>> +
>> + ret = gpmc_cs_request(cs, res.end - res.start, &base);
>
> How about using resource_size() above?
>
> BTW, I believe it's size = end - start + 1.
Thanks, yes I can update.
Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
