Hi, I think Vaibhav has covered most of the ground here, but just a few comments: On Fri, 15 Feb 2013, Felipe Balbi wrote: > On Thu, Feb 14, 2013 at 08:47:53PM +0000, Paul Walmsley wrote: > > > Drivers shouldn't touch their IP block's SYSCONFIG registers. They don't > > why not ? It's part of the driver's address space anyway. It's not part > of the IP in question (usb, ethernet, etc) but it's part of the TI > wrapper which usually involves a bridge (ocp2scp, ocp2axi, etc) plus the > TI-specific integration registers (revision, sysc, syss...). > > So they're not part of the licensed IP, but they're part of the TI > wrapper around those. Ideally Linux drivers would be as independent as possible from their SoC- or board-specific integration. This includes bus integration, etc. That way, an IP block like UART, where most or all of the registers are shared with the common 8250 code, might be able to use a shared driver. Also, it should be noted that the TI wrapper isn't necessarily common to all TI SoCs :-) The wrapper bits and functions can change from TI SoC to SoC. > > have anything specifically to do with the underlying device IP block, but > > of course they do, soft reset touches the underlying IP, so does force > idle, no idle, etc. Force idle, no idle, etc. only affects what's reported to the PRCM via the SIdleAck/MStandbyReq lines. It shouldn't affect anything in the IP block itself. As far as reset goes, the chip-wide reset bits affect the IP block too, but we wouldn't put that code into the drivers :-) - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
