Hi, On Tue, Feb 19, 2013 at 11:50:37AM -0800, Kevin Hilman wrote: > >> The other problem is the where reset is need during runtime. Again, > >> what are the specific examples here? The one I can think of off the top > >> of my head is I2C, where it's needed in certain error recovery > >> scenarios. > > > > right, I still have a theory that it's not needed in that case either, > > though I haven't had time to try that out. > > Great, I hope it's not needed. I've asked several times in past as this > driver was converted to runtime PM, but was told it was required for > various reasons (which I can't remember anymore.) :-) just like I2C's revision register was broken and had no useful data or MUSB mode1 couldn't be made to work... right. Looking at the functional spec, there's no mention that we need to driver reset signal anywhere, we _do_ need to reinitialize the transfer-related registers (I2C_CON, I2C_CNT, I2C_SA), other than that, I can't think of a need for driving the reset signal. The bus specification isn't that stupid right ? Arbitration Lost and NACK are both expected bus conditions. My only concern is write underflow and read overflow, but I haven't been able to force that to happen yet. Even in those cases, I'd be very surprised if we really needed to driver the reset signal. > >> Here, we need a way for the driver itself to initiate a full reset. > >> Maybe a new runtime PM hook like ->runtime_reset() as Felipe has > >> suggested (though I'm not yet sure runtime PM is the right place for > >> this, since it's not strictly related to runtime PM). Or, if these are > > > > right, I agree with you but I couldn't think of a better place. Maybe we > > need a reset hook in struct device itself (as I suggested on another > > mail) but I'm not sure Greg would take it, unless we have a damn good > > reason. > > I'm starting to think a ->hardreset() method in struct dev_pm_ops is the > place to put this. > > IMO, it needs to be in dev_pm_ops, so it can be selectively overridden > by PM domains. On OMAP, we'd just hook it up to omap_device_shutdown() > for all omap_devices, and we'd be done. do you mean omap_device_shutdown(); omap_device_enable(); ? > >> one have the other use cases handy? > > > > dwc3 gets reset during probe() too, but that has an IP specific reset > > which doesn't need SYSCONFIG register for that. > > OK, but that's still an init-time reset issue yeah, and this is pretty mandatory otherwise dwc3 and its PHYs (USB3 pair plus USB2) won't synchronize and we'll have all sorts of issues :-) > Do you know of any other runtime reset cases? If I2C is the only one, > then maybe seeing if it can be removed is the right first step. If that > works, we don't need any of this. I don't know of any other, but there might be a few... On the other hand, I doubt there's any of them which is truly necessary, unless there's a bug in the IP which we can solve by issuing a reset, other than that, driving the reset signal shouldn't be necessary outside of probe() (or something before probe()). -- balbi
Attachment:
signature.asc
Description: Digital signature
