Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > On Friday 15 February 2013 09:10 PM, Kevin Hilman wrote: >> Felipe Balbi <balbi@xxxxxx> writes: >> >>> Currently the omap-serial driver will not >>> work properly if booted via DT with CPUIDLE >>> enabled because it depends on function pointers >>> provided by hwmod to change its own SYSCONFIG >>> register. >>> >>> Remove that relyance on hwmod by moving SYSCONFIG >>> handling to driver itself. Note that this also >>> fixes a possible corner case bug where we could >>> be putting UART in Force Idle mode if we called >>> omap_serial_enable_wakeup(up, false) after setting >>> NOIDLE to the idle mode. This is because hwmod >>> has no protection against that situation. >>> >>> NYET-Signed-off-by: Felipe Balbi <balbi@xxxxxx> >> >> Here's another approach to getting rid of the sysconfig twiddling in the >> driver. I wrote this some time ago at my former company ;) but don't >> think I ever got around to posting it. >> >> It doesn't solve the whole problem (e.g. doesn't address the >> context_loss or enable_wakeup func pointers), but at least gets rid of >> the need for any SYSCONFIG access in the driver for the idle modes. >> >> Needs more thorough testing. >> > I posted similar patch series[1] yesterday after testing it on OMAP4/5 > devices. OMAP3 testing seems to be ok as well. AM3XXX and OMAP2 test > results is what am waiting for. Yeah, I saw yours after I posted mine. Just continue with yours, I'll be glad to have someone else take this on. > Good to know that you had similar idea in mind to get rid of > UART sysc hackery. Likewise. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
