Hi, On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: > I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel > driver ADP1653 is already in upstream kernel. Board code was extracted > from this big camera meego patch: > > https://api.pub.meego.com/public/source/CE:Adaptation:N900/kernel-adaptation-n900/linux-2.6-Camera-for-Meego-N900-Adaptation-kernel-2.6.37-patch.patch You need to sign-off the patch. > --- /dev/null > +++ b/arch/arm/mach-omap2/board-rx51-camera.c I'm not sure if adding a new file is sensible. There are already 3 board files for RX-51, which I think is overkill. > @@ -0,0 +1,177 @@ > +/* > + * arch/arm/mach-omap2/board-rx51-camera.c > + * > + * Copyright (C) 2008 Nokia Corporation > + * > + * Contact: Sakari Ailus <sakari.ailus@xxxxxxxxx> > + * Tuukka Toivonen <tuukka.o.toivonen@xxxxxxxxx> You should put these people to CC... Just to see if the addresses are still valid (which I doubt). > +static int __init rx51_adp1653_init(void) > +{ > + int err; > + > + err = gpio_request(ADP1653_GPIO_ENABLE, "adp1653 enable"); > + if (err) { > + printk(KERN_ERR ADP1653_NAME > + " Failed to request EN gpio\n"); > + err = -ENODEV; > + goto err_omap_request_gpio; > + } > + > + err = gpio_request(ADP1653_GPIO_INT, "adp1653 interrupt"); > + if (err) { > + printk(KERN_ERR ADP1653_NAME " Failed to request IRQ gpio\n"); > + err = -ENODEV; > + goto err_omap_request_gpio_2; > + } > + > + err = gpio_request(ADP1653_GPIO_STROBE, "adp1653 strobe"); > + if (err) { > + printk(KERN_ERR ADP1653_NAME > + " Failed to request STROBE gpio\n"); > + err = -ENODEV; > + goto err_omap_request_gpio_3; > + } > + > + gpio_direction_output(ADP1653_GPIO_ENABLE, 0); > + gpio_direction_input(ADP1653_GPIO_INT); > + gpio_direction_output(ADP1653_GPIO_STROBE, 0); gpio_request_array() should be used. > +void __init rx51_camera_init(void) > +{ > + if (rx51_camera_hw_init()) { > + printk(KERN_WARNING "%s: Unable to initialize camera\n", > + __func__); > + return; > + } > + > + if (omap3_init_camera(&rx51_isp_platform_data) < 0) > + printk(KERN_WARNING "%s: Unable to register camera platform " > + "device\n", __func__); pr_warn() should be used. A. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
