On Sun, Feb 10, 2013 at 12:35:43PM +0100, Javier Martinez Canillas wrote: > On Sun, Feb 10, 2013 at 10:37 AM, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxxx> wrote: > > On Sun, Feb 10, 2013 at 02:49:21AM +0100, Javier Martinez Canillas wrote: > >> I knew this would be controversial and that's why I didn't mean it to be a patch > >> but a RFC :) > >> > >> The problem basically is that you have to associate the platform device with its > >> corresponding DT device node because it can be used in the driver probe function. > > > > When DT is being used, doesn't DT create the platform devices for you, > > with the device node already set correctly? > > > > Well they usually do but not always just like usually you have a > platform_device in your board code and call platform_device_register(). > > But in some configurations you can't just define the platform_device > required resources (I/O memory, IRQ, etc) as static platform data. > In some cases you need a level of indirection. > > In this particular case a SMSC ethernet chip is connected to an > OMAP3 processor through its General-Purpose Memory Controller. > > You can't just define the I/O memory used by the device since you first > need to request that address to the GPMC. The same happens with the > IRQ line since a OMAP GPIO pin is used so you have to first configure > the GPIO line as input. For the gpio interrupt you can use, example taken from omap4-var-som.dts: interrupt-parent = <&gpio6>; interrupts = <11>; /* gpio line 171 */ Other architectures allow to specify the edge/level hi/low active parameters from the devicetree aswell. The gpio direction should be handled by the gpio driver as necessary, at least that's what done on other architectures. If the SMSC hangs on the GPMC then the SMSC should be a child node of the GPMC. The GPMC would then act as a bus driver and configure the chipselects and timings for its children automatically, maybe based on timing information from the devicetree. I've never tried this before, but I think that's the way things should be. No need to manually create platform devices from the devicetree. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
