Hi Mark, just FYI, these patches caused several warnings from sparse: > arch/arm/mach-omap2/omap_hwmod_2xxx_interconnect_data.c:141:30: warning: symbol 'omap2xxx_sham_addrs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_2xxx_interconnect_data.c:150:30: warning: symbol 'omap2xxx_aes_addrs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c:884:28: warning: symbol 'omap2_sham_mpu_irqs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c:889:28: warning: symbol 'omap2_sham_sdma_chs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c:927:28: warning: symbol 'omap2_aes_sdma_chs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_33xx_data.c:540:28: warning: symbol 'am33xx_aes0_edma_reqs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_33xx_data.c:579:28: warning: symbol 'am33xx_sha0_edma_reqs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c:3564:28: warning: symbol 'omap3_sham_mpu_irqs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c:3569:28: warning: symbol 'omap3_sham_sdma_reqs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c:3574:19: warning: symbol 'omap3xxx_sham_hwmod' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c:3630:28: warning: symbol 'omap3_aes_sdma_reqs' was not declared. Should it be static? > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c:3636:19: warning: symbol 'omap3xxx_aes_hwmod' was not declared. Should it be static? I've fixed them up here, but please don't forget to make sure that patches don't add any sparse warnings. sparse info is here: https://sparse.wiki.kernel.org/index.php/Main_Page regards, - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html