On 02/08/2013 01:55 AM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Feb 07, 2013 at 07:05:06PM -0600, Jon Hunter wrote:
>> If the device-tree blob is present during boot, then register the SDMA
>> controller with the device-tree DMA driver so that we can use device-tree
>> to look-up DMA client information.
>>
>> Signed-off-by: Jon Hunter <jon-hunter@xxxxxx>
>
> single comment below, other than that:
>
> Reviewed-by: Felipe Balbi <balbi@xxxxxx>
>
>> ---
>> arch/arm/mach-omap2/dma.c | 4 ++++
>> drivers/dma/omap-dma.c | 37 +++++++++++++++++++++++++++++++++++--
>> 2 files changed, 39 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
>> index 5cd8d76..71dadff 100644
>> --- a/arch/arm/mach-omap2/dma.c
>> +++ b/arch/arm/mach-omap2/dma.c
>> @@ -28,6 +28,7 @@
>> #include <linux/init.h>
>> #include <linux/device.h>
>> #include <linux/dma-mapping.h>
>> +#include <linux/of.h>
>> #include <linux/omap-dma.h>
>>
>> #include "soc.h"
>> @@ -304,6 +305,9 @@ static int __init omap2_system_dma_init(void)
>> if (res)
>> return res;
>>
>> + if (of_have_populated_dt())
>> + return res;
>> +
>> pdev = platform_device_register_full(&omap_dma_dev_info);
>> if (IS_ERR(pdev))
>> return PTR_ERR(pdev);
>> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
>> index c4b4fd2..0067bd0 100644
>> --- a/drivers/dma/omap-dma.c
>> +++ b/drivers/dma/omap-dma.c
>> @@ -16,6 +16,8 @@
>> #include <linux/platform_device.h>
>> #include <linux/slab.h>
>> #include <linux/spinlock.h>
>> +#include <linux/of_dma.h>
>> +#include <linux/of_device.h>
>>
>> #include "virt-dma.h"
>>
>> @@ -67,6 +69,8 @@ static const unsigned es_bytes[] = {
>> [OMAP_DMA_DATA_TYPE_S32] = 4,
>> };
>>
>> +static struct of_dma_filter_info info;
>
> Arnd also mentioned that since all fields belonging to this are
> constant, you could statically initialize them here. He also mentioned
> you should call this by a more descriptive name:
Oops sorry missed that comment. Will fix up and re-send.
Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
