Re: [PATCH] ARM: dts: omap3-igep: Add fixed always-on regulators to common dtsi file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 29, 2012 at 10:04 PM, Ezequiel Garcia
<ezequiel.garcia@xxxxxxxxxxxxxxxxxx> wrote:
> These regulators are common to igep0020 and igep0030 boards
> and are needed by smsc911x controller.
>
> Cc: Benoît Cousson <b-cousson@xxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Enric Balletbo i Serra <eballetbo@xxxxxxxxx>
> Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/omap3-igep.dtsi |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
> index dd01c46..91a42ce 100644
> --- a/arch/arm/boot/dts/omap3-igep.dtsi
> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
> @@ -24,6 +24,18 @@
>                 ti,mcbsp = <&mcbsp2>;
>                 ti,codec = <&twl_audio>;
>         };
> +
> +        vddvario: regulator-vddvario {
> +                compatible = "regulator-fixed";
> +                regulator-name = "vddvario";
> +                regulator-always-on;
> +        };
> +
> +        vdd33a: regulator-vdd33a {
> +                compatible = "regulator-fixed";
> +                regulator-name = "vdd33a";
> +                regulator-always-on;
> +        };
>  };
>
>  &omap3_pmx_core {

Hi Ezequiel,

This shouldn't be defined on the generic omap3-igep.dtsi but on
omap3-igep0020.dts since the IGEP COM Module doesn't have the LAN
SMSC9221 chip which is the one using these regulators.

Otherwise, the patch looks good to me and I think it has to be part of
the series that add SMSC9221 support for IGEPv2.

Thanks a lot and best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux