Hi Paul, On Sun, Dec 09, 2012 at 06:53:43, Paul Walmsley wrote: > The atomic usecounts seem to be confusing, and are no longer needed > since the operations that they are attached to really should take > place under lock. Replace the atomic counters with simple integers, > protected by the enclosing powerdomain spinlock. [...] > > @@ -1063,7 +1123,8 @@ static int _clkdm_clk_hwmod_enable(struct clockdomain *clkdm) > * should be called for every clock instance or hwmod that is > * enabled, so the clkdm can be force woken up. > */ > - if ((atomic_inc_return(&clkdm->usecount) > 1) && autodeps) { > + clkdm->usecount++; > + if (clkdm->usecount > 1 && autodeps) { > pwrdm_unlock(clkdm->pwrdm.ptr); > return 0; > } This is not directly related to this patch but something I noticed when I enabled the various debug prints. if the clkdm->usecount is > 1, there is still a call to arch_clkdm->clkdm_clk_enable(). Won't the usecount >1 guarantee that the clkdm is in the right state and the PRCM access can be skipped? Regards, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html