On Thu, 6 Dec 2012 11:52:07 +0100, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote: > This GPIO driver should not configure anything else then GPIOs. > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx> I'm not sure if this is the right direction. I actually have no problem with a single driver that registers itself with multiple interfaces (ie. GPIO and PWM) if it makes sense for it to do so. I suspec that a lot of the multifunction device drivers break things up more than is strictly necessary. I'll still apply this if you think it is the right direction, but I wanted to throw that though out there for consideration. g. > --- > drivers/gpio/gpio-twl4030.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c > index a38e6e9c..1e9f08c4 100644 > --- a/drivers/gpio/gpio-twl4030.c > +++ b/drivers/gpio/gpio-twl4030.c > @@ -47,6 +47,7 @@ > * intended to support multiple hosts. > * > * There are also two LED pins used sometimes as output-only GPIOs. > + * TODO: Handling of PWMA/B (LEDA/B) should be removed from this GPIO driver! > */ > > /* genirq interfaces are not available to modules */ > @@ -131,6 +132,7 @@ static inline int gpio_twl4030_read(u8 address) > > /*----------------------------------------------------------------------*/ > > +/* TODO: Handling of PWMA/B (LEDA/B) should be removed from this GPIO driver! */ > static u8 cached_leden; > > /* The LED lines are open drain outputs ... a FET pulls to GND, so an > -- > 1.8.0 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
