On 2012-12-15 23:08, NeilBrown wrote:
>
> commit 195e672a76056478cc79f5c48343164c9237852e
> OMAPDSS: DPI: Remove cpu_is_xxxx checks
>
> made the mistake of assuming that cpu_is_omap34xx() is exclusive of
> other cpu_is_* predicates whereas it includes cpu_is_omap3630().
>
> So on an omap3630, code that was previously enabled by
> if (cpu_is_omap34xx())
> is now disabled as
> dss_has_feature(FEAT_DPI_USES_VDDS_DSI)
> fails.
>
> So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list.
>
> Cc: Chandrabhanu Mahapatra <cmahapatra@xxxxxx>
> Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> Signed-off-by: NeilBrown <neilb@xxxxxxx>
>
> diff --git a/drivers/video/omap2/dss/dss_features.c b/drivers/video/omap2/dss/dss_features.c
> index acbc1e1..aaf3c3f 100644
> --- a/drivers/video/omap2/dss/dss_features.c
> +++ b/drivers/video/omap2/dss/dss_features.c
> @@ -546,6 +546,7 @@ static const enum dss_feat_id omap3630_dss_feat_list[] = {
> FEAT_ALPHA_FIXED_ZORDER,
> FEAT_FIFO_MERGE,
> FEAT_OMAP3_DSI_FIFO_BUG,
> + FEAT_DPI_USES_VDDS_DSI,
> };
>
> static const enum dss_feat_id omap4430_es1_0_dss_feat_list[] = {
>
Thanks, looks correct. Did you encounter a bug related to this, or just
happened to notice?
Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
