>>>>> "Thierry" == Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> writes: Hi, >> There's several different situations: >> >> - Platform without pinctrl support >> - Platform with pinctrl support but no pinmux specified in dt for device >> (E.G. pinmux setup in bootloader) >> - Pinmux specified in dt >> - Some kind of misconfiguration in dt >> >> You could argue that devm_pinctrl_get_select_default() shouldn't return >> an error for the first situation, but how should it be able to know the >> difference between 2 and 4? Thierry> In case where the platform supports pinctrl but no pinmux is specified Thierry> for the device it should just assume that no pinmuxing is needed. That Thierry> sounds like the most logical behaviour to me. In those cases pinctrl Thierry> could just assume that the default has already been selected and not Thierry> return an error. Agreed. Thierry> But you can't reasonably expect to cope with misconfigured DT Thierry> content. Heck, there's no way for you to even know if it is Thierry> misconfigured. With 'misconfigured DT' I just mean any kind of real error. Thierry> That said, I'm not sure how much of an issue this really Thierry> is. Pinmuxing is only used for functions local to a given Thierry> chip, right? So if an SoC supports pinctrl and a given Thierry> peripheral needs pinmuxing then we can reasonably assume that Thierry> your second case can't happen, can't we? Well, peripherals only need pinmuxing if the bootloader didn't already set it up in advance. We could naturally enforce people to add "redundant" pinmux info to their .dts files, but I'm not sure I like that idea. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
