On Mon, Nov 26, 2012 at 5:22 PM, Felipe Balbi <balbi@xxxxxx> wrote: > Hi, > > On Mon, Nov 26, 2012 at 05:09:42PM +0530, Shubhrajyoti D wrote: >> The OMAP_I2C_IP_VERSION_1 and OMAP_I2C_IP_VERSION_2 was needed >> as on VER2 we were not reading all the 32-bits. Since now that >> we read the hi register we do not need the OMAP_I2C_IP_VERSION_*. >> Delete the same. >> >> The custom reset is also changed to detect VER2 based on the >> scheme. > > looks like this should become a series IMO. > > First patch would move the macros to common header, second patch would > switch the Reset part to use those macros and third patch gets rid of > OMAP_I2C_IP_VERSION_* > > other than that, looks very good to me. OK will respin it accordingly. > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html