On Tue, Nov 20, 2012 at 10:56:22AM +0100, Peter Ujfalusi wrote:
> The driver supports the following LED outputs as generic PWM driver:
> TWL4030 LEDA and LEDB (PWMA and PWMB)
> TWL6030 Charging indicator LED (PWM LED)
>
> On TWL6030 when the PWM requested LED is configured to be controlled by SW.
> In this case the user can enable/disable and set the duty period freely.
> When the PWM has been freed, the LED driver is put back to HW control.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> ---
> drivers/pwm/Kconfig | 10 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-twl-led.c | 303 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 314 insertions(+)
> create mode 100644 drivers/pwm/pwm-twl-led.c
Doesn't this belong in the drivers/leds subsystem? Besides that, the
same comments as for the previous patch apply. One additional note
below.
> +static struct platform_driver twl_pwmled_driver = {
> + .driver = {
> + .name = "twl-pwmled",
> + .of_match_table = of_match_ptr(twl_pwmled_of_match),
> + },
> + .probe = twl_pwmled_probe,
> + .remove = __devexit_p(twl_pwmled_remove),
You didn't annotate twl_pwmled_remove() with __devexit, so __devexit_p
isn't needed here either.
Thierry
Attachment:
pgpcNN14uKEZu.pgp
Description: PGP signature
