On 23.11.2012 11:47, Peter Korsgaard wrote: >>>>>> "Daniel" == Daniel Mack <zonque@xxxxxxxxx> writes: > > Hi, > > D> + Layouts for 1-bit ecc: stored at beginning of spare area as romcode: > D> + > D> + "hw-romcode" gpmc method & romcode layout > D> + "bch4" 4-bit BCH ecc code > D> + "bch8" 8-bit BCH ecc code > D> + > >> > >> These are not 1-bit - Well, romcode might be depending on SoC. Looking at > >> omap2.c it seems to be an alias for hw, so that isn't really helpful on > >> E.G. am33xx where you should select bch8 to have something compatible > >> with the romcode. > > Daniel> Not sure whether I follow you here. drivers/mtd/nand/omap2.c handles > Daniel> cases for pdata->ecc_opt == OMAP_ECC_BCH8_CODE_HW, so the DT bindings > Daniel> need to offer a way to set it. > > Daniel> Or are you purely referring to the comments only? > > Yes, but the document states (the first line I'm quotinge) 'Layouts for > 1-bit ecc'. Ok, I guess I'll just remove these comments then. > The other comment was about hw-romcode not being a very good > name, as it apparently means the 1bit hamming code and ECC layout used > on the older omap3, and not E.G. the bch8/elm layout used by > E.G. am335x. So which name would you pick? "bch1"? > As discussed elsewhere, the elm also changes the ECC layout, so why not > just have bchN (software bchN layout) / bchN-elm selections instead of > the seperate ti,nand-ecc-use-elm? Avinash - what do you think? Thanks for the feedback - I'd also like to get these bindings right in the first place. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
