On 11/22/2012 03:56 PM, Felipe Balbi wrote: > Hi, > > On Thu, Nov 22, 2012 at 09:49:05PM +0800, Andy Green wrote: >>> Again it sounds like something that should be done at the hub driver >>> level. I mean using the GPIO (for reset) and Power Regulator. >>> >>> not implementing the regulator part itself, but using it. >> >> If you mean change the regulator managing code from living in >> omap-hsusb to ehci-hcd, it sounds like a good idea. > > I mean that drivers/usb/core/hub.c should manage it, since that's what > actually manages the HUB entity. Yes. I agree that powering up the on-board hubs should be done generically and not in ehci-omap.c. I'm not sure how it can be done in hub.c. I'm assuming that such problem is limited to root hub ports where system designers have the flexibility to provide power to the peripherals outside the USB Hub specification. I can think of two solutions 1) Associate the regulators with the root hub _ports_ and enable them as part of port's power-up routine. 2) Have a global list of regulators that are registered by platform code and enabled them all at once on hcd init. Any clues on how (1) could be implemented? -- cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html