On Fri, Nov 9, 2012 at 9:17 AM, Mark A. Greer <mgreer@xxxxxxxxxxxxxxx> wrote: > On Fri, Nov 09, 2012 at 06:28:16PM +0200, Kasatkin, Dmitry wrote: >> On Wed, Nov 7, 2012 at 4:57 AM, Mark A. Greer <mgreer@xxxxxxxxxxxxxxx> wrote: >> > From: "Mark A. Greer" <mgreer@xxxxxxxxxxxxxxx> >> > >> > Remove usage of the private OMAP DMA API. >> > The dmaengine API will be used instead. >> > >> > CC: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> >> > CC: Dmitry Kasatkin <dmitry.kasatkin@xxxxxxxxx> >> > Signed-off-by: Mark A. Greer <mgreer@xxxxxxxxxxxxxxx> >> > --- >> > drivers/crypto/omap-sham.c | 117 --------------------------------------------- >> > 1 file changed, 117 deletions(-) >> > >> > diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c >> > index b57277c..ebb5255 100644 >> > --- a/drivers/crypto/omap-sham.c >> > +++ b/drivers/crypto/omap-sham.c > >> > @@ -807,18 +762,6 @@ static int omap_sham_handle_queue(struct omap_sham_dev *dd, >> > if (err) >> > goto err1; >> > >> > -#ifdef OMAP_SHAM_DMA_PRIVATE >> > - omap_set_dma_dest_params(dd->dma_lch, 0, >> > - OMAP_DMA_AMODE_CONSTANT, >> > - dd->phys_base + SHA_REG_DIN(0), 0, 16); >> > - >> > - omap_set_dma_dest_burst_mode(dd->dma_lch, >> > - OMAP_DMA_DATA_BURST_16); >> > - >> > - omap_set_dma_src_burst_mode(dd->dma_lch, >> > - OMAP_DMA_DATA_BURST_4); >> >> Burst mode significantly improves performance. >> How do you configure burst mode with new API? > > This is (or should be) taken care of by the dmaengine infrastructure. > I've noted that there's an issue and there is a discussion about it > here: > > http://www.spinics.net/lists/linux-omap/msg79855.html > > We probably need to extend the dmaengine API to allow API-users to > request specific tweaks/optimizations/whatever but that's MHO. > Hello, I am in favor of new APIs. The only my concern is that it performs worse.. Is it possible to keep burst mode setting there? - Dmitry > Mark > -- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
