Felipe Balbi <balbi@xxxxxx> writes: > HI, > > On Fri, Nov 09, 2012 at 04:30:35PM +0200, Tero Kristo wrote: >> Commit c9e4412ab8eb8ef82d645d8749c4ce96ad490007 removed all of the USB >> PHY functions for OMAP4, but this causes a problem with core retention >> as the MUSB module remains enabled if omap-usb2 phy driver is not used. >> This keeps the USB DPLL enabled and prevents l3_init pwrdm from idling. >> >> Fixed by adding a minimal function back that disables the USB PHY during >> boot. >> >> Signed-off-by: Tero Kristo <t-kristo@xxxxxx> >> Cc: Kishon Vijay Abraham I <kishon@xxxxxx> >> Cc: Felipe Balbi <balbi@xxxxxx> >> Cc: Tony Lindgren <tony@xxxxxxxxxxx> >> Cc: Kevin Hilman <khilman@xxxxxx> > > looks good to me. I would still suggest adding a REVISIT or FIXME note > stating that this should be moved to SCM driver eventually ;-) > > Other than that: > > Acked-by: Felipe Balbi <balbi@xxxxxx> Thanks will try to get this in for v3.8 along with the original patch 4/9 which gets full-chip retention working on OMAP4. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html