Hi Stephen, On 5 November 2012 21:40, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 11/05/2012 07:55 PM, Omar Ramirez Luna wrote: >> Actually moving it from plat-omap, as this framework/driver code is >> supposed to be under drivers/ folder. The framework should work with >> the current supported OMAP processors (OMAP1+) that have mailbox and >> can be used as a method of interprocessor communication. >> >> The mailbox hardware (in OMAP) uses a queued mailbox-interrupt mechanism >> that provides a communication channel between processors through a set of >> registers and their associated interrupt signals by sending and receiving >> messages. > >> diff --git a/drivers/mailbox/mailbox.h b/drivers/mailbox/mailbox.h > > Is this a public interface to the driver? If so, shouldn't the header be > in include/linux somewhere? > > Is this a generic interface to any mailbox driver? If so, then I don't > think having "omap" in the symbol names is appropriate. If the header is > specific to the OMAP driver, I don't think using the very generic > filename "mailbox.h" is appropriate; use omap_mailbox.h instead? It was a mixture between the two, the next patch splits the API from the mailbox driver interfaces. I kept the files named as plain mailbox.[ch], in hopes that we could progress with the cleanup after moving the files from plat-omap, as it seems they interfere with the current single Image effort, but if it is preferred (as it seems to be) I can resend again after removing the omap_ prefixes from the intended-to-be generic code. Thanks, Omar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
