On Mon, Nov 05, 2012 at 23:27:52, Bedia, Vaibhav wrote: > On Mon, Nov 05, 2012 at 12:28:36, Hiremath, Vaibhav wrote: > [...] > > > - u32 mask = 1 << shift; > > > - > > > - /* Check the current status to avoid de-asserting the line twice */ > > > - if (am33xx_prm_is_hardreset_asserted(shift, inst, rstctrl_offs) == 0) > > > - return -EEXIST; > > > > Any specific reason why you have removed this check? > > During bootup the hardreset line is asserted, so wouldn't that check lead > to the function always returning without doing anything? > The check is, /* Check the current status to avoid de-asserting the line twice */ if (am33xx_prm_is_hardreset_asserted(shift, inst, rstctrl_offs) == 0) return -EEXIST; The code is checking whether the line is already de-asserted (== 0), so I am not sure how this will change if hardreset line is asserted during bootup. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
