On Sat, Nov 03, 2012 at 21:40:37, Shilimkar, Santosh wrote:
[...]
> > +#if defined(CONFIG_SOC_AM33XX)
> > + else if (soc_is_am33xx()) {
> > + list = am33xx_mboxes;
> > +
> > + list[0]->irq = platform_get_irq(pdev, 0);
> > + }
> > +#endif
> #ifdef in middle of the function looks really ugly. But I can't complain
> just for your patch because looks like rest of the mailbox code is
> flooded with #ifdeffery.
>
> Mailbox needs cleanup. and probably can be moved out of
> arch/arm/*omap*/ to some driver directory.
>
Tony pointed out that the movement to drivers directory
is underway [1]. Getting rid of the #ifdeffery could be next.
Regards,
Vaibhav
[1] http://www.spinics.net/lists/linux-omap/msg80702.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
