Hi Mike, Mike Turquette <mturquette@xxxxxx> writes: > From: Mike Turquette <mturquette@xxxxxxxxxx> > > This series creates a new callback for struct voltagedomain, > .get_voltage. This fetches the voltage from hardware, if possible, and > returns it to the caller. We use this call to populate > voltdm->nominal_volt at boot time. I pointed out a couple nitpicky things on individual patches, but otherwise this direction and motiviation for this series looks OK by me. Just some minor comments about the structure of the series. I tend to prefer combining the introduction of a new function with it's usage. It makes review and understanding much easier, IMO. If there are reasons to keep them separate, that's fine too. Just describe the reasons in the cover letter. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
