Hi Mark, "Mark A. Greer" <mgreer@xxxxxxxxxxxxxxx> writes: > From: "Mark A. Greer" <mgreer@xxxxxxxxxxxxxxx> > > Convert the omap-sham crypto driver to use the > pm_runtime API instead of the clk API. > > CC: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > CC: Paul Walmsley <paul@xxxxxxxxx> > CC: Dmitry Kasatkin <dmitry.kasatkin@xxxxxxxxx> > Signed-off-by: Mark A. Greer <mgreer@xxxxxxxxxxxxxxx> I can't pretend to fully understand this driver, It looks like the current code is doing a bit more fine-grained clock gating, and leaving the IP clocked only when needed. The proposed version does a 'get' in probe and a 'put' in remove, which means the IP will always be enabled (and thus preventing low-power states), even when it's not in use. If that's really needed, it should be thoroughly described in the changelog, otherwise I suggest doing the runtime PM 'get' and 'put' in roughtly the same spots as the current clk enable/disable which makes this a more straight-forward conversion. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
