On 10/18/2012 9:23 PM, Daniel Mack wrote: > This is needed as preparation for platforms where using pm runtime usage > is mandatory. > > Signed-off-by: Daniel Mack <zonque@xxxxxxxxx> It looks like, you just duplicated effort here. RTC patches have been already submitted quite some time back for AM33xx, probably you missed to do google before spending time on this. Patch Series - http://www.mail-archive.com/davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx/msg23253.html Denial, It would be really helpful if you could test these patches and ack them. Just FYI, we have bunch of parallel activities going inside team to upstream all the patches/module/drivers/features, so to avoid such duplication of effort, I suggest you to google for the patches or ping on mailing list. Thanks, Vaibhav > --- > drivers/rtc/rtc-omap.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c > index 0b614e3..baa876e 100644 > --- a/drivers/rtc/rtc-omap.c > +++ b/drivers/rtc/rtc-omap.c > @@ -17,6 +17,7 @@ > #include <linux/module.h> > #include <linux/ioport.h> > #include <linux/delay.h> > +#include <linux/pm_runtime.h> > #include <linux/rtc.h> > #include <linux/bcd.h> > #include <linux/platform_device.h> > @@ -322,6 +323,9 @@ static int __init omap_rtc_probe(struct platform_device *pdev) > goto fail; > } > > + pm_runtime_enable(&pdev->dev); > + pm_runtime_get_sync(&pdev->dev); > + > rtc = rtc_device_register(pdev->name, &pdev->dev, > &omap_rtc_ops, THIS_MODULE); > if (IS_ERR(rtc)) { > @@ -420,6 +424,8 @@ static int __exit omap_rtc_remove(struct platform_device *pdev) > free_irq(omap_rtc_alarm, rtc); > > rtc_device_unregister(rtc); > + pm_runtime_put_sync(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > iounmap(rtc_base); > release_mem_region(mem->start, resource_size(mem)); > return 0; > @@ -442,11 +448,15 @@ static int omap_rtc_suspend(struct platform_device *pdev, pm_message_t state) > else > rtc_write(0, OMAP_RTC_INTERRUPTS_REG); > > + pm_runtime_put_sync(&pdev->dev); > + > return 0; > } > > static int omap_rtc_resume(struct platform_device *pdev) > { > + pm_runtime_get_sync(&pdev->dev); > + > if (device_may_wakeup(&pdev->dev)) > disable_irq_wake(omap_rtc_alarm); > else > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
