Re: [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/18/2012 11:25 AM, Peter Ujfalusi wrote:
> Fixes the following errors:
> [    2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
> [    2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
> 
> Which is because we failed to link the sidetone hwmod for McBSP2/3. The
> missing sidetone hwmod link will prevent omap_device_alloc() to append the
> DMA resources since we - accidentally - end up having the same number of
> resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports
> without the ST resources.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>

Acked-by: Benoit Cousson <b-cousson@xxxxxx>

Regards,
Benoit

> ---
> 
> Hi Tony, Benoit,
> 
> Can you please take this patch for 3.7 since if we boot with DT audio will not
> work on BeagleBoard and on boards which uses McBSP2 or 3 for audio.
> 
> Thank you,
> Peter
> 
>  arch/arm/boot/dts/omap3.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index f38ea87..696e929 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -257,7 +257,7 @@
>  			interrupt-names = "common", "tx", "rx", "sidetone";
>  			interrupt-parent = <&intc>;
>  			ti,buffer-size = <1280>;
> -			ti,hwmods = "mcbsp2";
> +			ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
>  		};
>  
>  		mcbsp3: mcbsp@49024000 {
> @@ -272,7 +272,7 @@
>  			interrupt-names = "common", "tx", "rx", "sidetone";
>  			interrupt-parent = <&intc>;
>  			ti,buffer-size = <128>;
> -			ti,hwmods = "mcbsp3";
> +			ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
>  		};
>  
>  		mcbsp4: mcbsp@49026000 {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux