On Mon, 2012-09-17 at 13:52 +0300, Grazvydas Ignotas wrote: > On Thu, Sep 13, 2012 at 6:06 PM, Raphael Assenat <raph@xxxxxx> wrote: > > When the omap2 nand flash driver is used, the nand-disk led trigger does not > > work due to nand_wait_ready not being called. > > I think better solution is just to delete omap_wait() function, which > is just a copy of nand_wait() without LED and oops handling. If > waitfunc is not set by the driver, default nand_wait is used by the > core. Or if it does really need own wait function, we can re-work the internal api similarly to what we did to MTD api. Instead of calling 'chip->waitfunc()' directly from everywhere, have a wrapper 'nand_wati()' function, which can do things common to all drivers, and then actually call the underlying '->waitfunc()'. So in this case, it can do the LED stuff. -- Best Regards, Artem Bityutskiy
Attachment:
signature.asc
Description: This is a digitally signed message part
