Re: [PATCH v9 3/3] ARM: OMAP2+: gpmc: minimal driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Tue, 11 Sep 2012, Afzal Mohammed wrote:

> Create a minimal driver out of gpmc code.
> Responsibilities handled by earlier gpmc
> initialization is now achieved in probe.
> 
> Signed-off-by: Afzal Mohammed <afzal@xxxxxx>
> Reviewed-by: Jon Hunter <jon-hunter@xxxxxx>

Two checkpatch warnings are added by this patch:

CHECK: multiple assignments should be avoided
#77: FILE: arch/arm/mach-omap2/gpmc.c:454:
+	res->start = res->end = 0;

CHECK: Alignment should match open parenthesis
#216: FILE: arch/arm/mach-omap2/gpmc.c:936:
+	dev_info(gpmc_dev, "GPMC revision %d.%d\n",
+				GPMC_REVISION_MAJOR(l), GPMC_REVISION_MINOR(l));

I've fixed them here in the obvious way.  But please make sure that all 
your patches are clean with 'checkpatch.pl --strict'; saves us time and 
frustration...


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux