On Wed, Sep 12, 2012 at 06:50:00PM +0530, R, Sricharan wrote: > Hi, > On Wed, Sep 12, 2012 at 6:27 PM, Shilimkar, Santosh > <santosh.shilimkar@xxxxxx> wrote: > > On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@xxxxxx> wrote: > >> > >> On 9/12/2012 1:50 AM, R Sricharan wrote: > >>> > >>> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, > >>> the feature is not getting selected. > >>> Adding a string description in the Kconfig resolves this. > >>> > >>> But not sure if this is the right way to fix this. > >>> > >> > >> Shouldn't you be selecting this in your 64-bit dma address capable arch > >> instead? > >> > > Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens > > in the arch which needs it. Since this option was made as simple bool, > > looks like because of some KCONFIG magic, it was not getting selected. > > Adding some help text does fix the issue and thats is the patch all about. > > > Correct. So even if you select this in the arch/defconfig, That is correct behaviour. You need an explicit "select DMA_ADDR_64BIT_T" somewhere in a Kconfig file to make it happen. Editing defconfigs is not how we enable these options. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
