Hi, On Wed, Sep 12, 2012 at 6:55 PM, Shilimkar, Santosh <santosh.shilimkar@xxxxxx> wrote: > On Wed, Sep 12, 2012 at 6:49 PM, Catalin Marinas > <catalin.marinas@xxxxxxx> wrote: >> On Wed, Sep 12, 2012 at 01:57:26PM +0100, Shilimkar, Santosh wrote: >>> On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy <cyril@xxxxxx> wrote: >>> > >>> > On 9/12/2012 1:50 AM, R Sricharan wrote: >>> >> >>> >> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, >>> >> the feature is not getting selected. >>> >> Adding a string description in the Kconfig resolves this. >>> >> >>> >> But not sure if this is the right way to fix this. >>> >> >>> > >>> > Shouldn't you be selecting this in your 64-bit dma address capable arch >>> > instead? >>> > >>> Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens >>> in the arch which needs it. Since this option was made as simple bool, >>> looks like because of some KCONFIG magic, it was not getting selected. >>> Adding some help text does fix the issue and thats is the patch all about. >> >> Are you sure you select this explicitly in Kconfig? It should not depend >> on a description. >> > You are right. > >> What I understood from the initial email was that this option was only >> added to the defconfig but ignored by the kernel as it's not a user >> selectable option (unless you add some text). >> > That's right. Explicit KCONFIG select should work. yes. It works when enabled in arch/KCONFIG. Thanks. This patch is not needed then. Thanks, Sricharan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
