Hi Tony,
On Tue, Sep 11, 2012 at 05:47:10, Tony Lindgren wrote:
> FYI, looks like a new warning got introduced, so I've
> committed the following trivial patch on top of this series.
I was not careful enough, sorry. Thanks for fixing it.
Another hunk as follows would also be required for error
path even though compiler didn't complain.
Not sure whether you can fixup or I should post as a
separate patch.
As an aside, there was compiler warning before this
series, but I didn't dare to touch it, so a warning
was seen but thought it was due to the earlier one.
And now Arnd has fixed the original warning.
Regards
Afzal
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 337cf0a..27293e3 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1404,6 +1404,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev)
info->gpmc_irq_count = platform_get_irq(pdev, 1);
if (info->gpmc_irq_count <= 0) {
dev_err(&pdev->dev, "error getting count irq\n");
+ err = -ENODEV;
goto out_release_mem_region;
}
err = request_irq(info->gpmc_irq_count, omap_nand_irq,
> From: Tony Lindgren <tony@xxxxxxxxxxx>
> Date: Mon, 10 Sep 2012 17:14:13 -0700
> Subject: [PATCH] mtd: nand omap2: Fix uninitialized err warning
>
> Commit bd4156fd (mtd: nand: omap2: use gpmc provided irqs)
> introduced a new warning:
>
> drivers/mtd/nand/omap2.c: In function ‘omap_nand_probe’:
> drivers/mtd/nand/omap2.c:1267: warning: ‘err’ may be used uninitialized in this function
>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
>
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1389,6 +1389,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev)
> info->gpmc_irq_fifo = platform_get_irq(pdev, 0);
> if (info->gpmc_irq_fifo <= 0) {
> dev_err(&pdev->dev, "error getting fifo irq\n");
> + err = -ENODEV;
> goto out_release_mem_region;
> }
> err = request_irq(info->gpmc_irq_fifo, omap_nand_irq,
>
��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
