On Thu, Jul 05, 2012 at 10:50:24AM +0530, Gupta, Ramesh wrote:
> static void flush_iopgd_range(u32 *first, u32 *last)
> {
> - /* FIXME: L2 cache should be taken care of if it exists */
> - do {
> - asm("mcr p15, 0, %0, c7, c10, 1 @ flush_pgd"
> - : : "r" (first));
> - first += L1_CACHE_BYTES / sizeof(*first);
> - } while (first <= last);
> + flush_iommu_mem(first, last);
> + outer_flush_range(virt_to_phys(first), virt_to_phys(last));
I think this would be safer if these operated on an area rather than a
range - which means taking a start plus size.
phys_addr_t phys = virt_to_phys(start);
iommu_flush_area(start, size);
outer_flush_range(phys, phys + size);
is safer than the above if virt_to_phys() is non-linear.
> *iopgd = virt_to_phys(iopte) | IOPGD_TABLE;
> - flush_iopgd_range(iopgd, iopgd);
> + flush_iopgd_range(iopgd, iopgd + 1);
And operating on a start + size also makes this kind of stuff clearer.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
