On Thu, Sep 6, 2012 at 8:59 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Peter Ujfalusi <peter.ujfalusi@xxxxxx> [120905 02:02]: >> Use the pcs->fmask to make sure that the value is not changing (setting) >> bits in areas where it should not. >> To avoid situations like this: >> >> pmx_dummy: pinmux@4a100040 { >> compatible = "pinctrl-single"; >> reg = <0x4a100040 0x0196>; >> #address-cells = <1>; >> #size-cells = <0>; >> pinctrl-single,register-width = <16>; >> pinctrl-single,function-mask = <0x00ff>; >> }; >> >> &pmx_dummy { >> pinctrl-names = "default"; >> pinctrl-0 = <&board_pins>; >> >> board_pins: pinmux_board_pins { >> pinctrl-single,pins = < >> 0x6c 0xf0f >> 0x6e 0x10f >> 0x70 0x23f >> 0x72 0xa5f >> >; >> }; >> }; >> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx> > > Thanks this is a valid fix: > > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> Since nothing in v3.6 is using pinctrl-simple yet, it's not a regression right? So can you just group this with the other pinctrl things you are harvesting in the OMAP tree? I was going to push it for the v3.7 cycle otherwise. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html