* Marek Vasut <marex@xxxxxxx> [120905 19:05]: > Hi Tony, > > > * Marek Vasut <marex@xxxxxxx> [120904 20:13]: > > > Dear Bryan Wu, > > > > > > > On Sat, Sep 1, 2012 at 4:16 PM, AnilKumar Ch <anilkumar@xxxxxx> wrote: > > > > > Adopt pinctrl support to leds-gpio driver based on leds-gpio > > > > > device pointer, pinctrl driver configure SoC pins to GPIO > > > > > mode according to definitions provided in .dts file. > > > > > > > > Thanks for this, actually Marek Vasut submitted a similar patch > > > > before. I'm pretty fine with this patch. > > > > > > Thanks for submitting this actually ... I didn't have time to properly > > > investigate this. > > > > > > > But without proper DT setting, it will also give us warning I think. > > > > or we can provide some dummy functions as a temp solution as Shawn > > > > pointed out before. > > > > > > But this driver is also used on hardware that's not yet coverted to DT, > > > so I'd say dev_warn() if CONFIG_OF is enabled and otherwise simply go on > > > ? Actually, can we not skip whole this pinctrl thing if CONFIG_OF is > > > disabled? Actually (2), what's the relationship between OF and pinctrl? > > > > The warning should be pinctrl related as the pinctrl drivers may not be > > device tree based drivers. > > Exactly my concern. Also the warning shouldnt be present on systems where > pinctrl is disabled. But pinctrl_get_select() returns 0 in include/linux/pinctrl/consumer.h if CONFIG_PINCTRL is not selected, so no warning is produced AFAIK ;) Or do you get some warning if CONFIG_PINCTRL is not selected for your hardware? Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
