Hi, On Thu, Sep 06, 2012 at 08:13:03PM +0300, Felipe Balbi wrote: > Hi, > > On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote: > > > > > > On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: > > > The mailbox register for usb otg in omap is present in control module. > > > On detection of any events VBUS or ID, this register should be written > > > to send the notification to musb core. > > > > > > Till we have a separate control module driver to write to control module, > > > omap2430 will handle the register writes to control module by itself. So > > > a new address space to represent this control module register is added > > > to usb_otg_hs. > > > > > > Cc: Benoit Cousson <b-cousson@xxxxxx> > > > Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > > > --- > > > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > > > index 242aee4..02341bc 100644 > > > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > > > @@ -5890,6 +5890,11 @@ static struct omap_hwmod_addr_space omap44xx_usb_otg_hs_addrs[] = { > > > .pa_end = 0x4a0ab003, > > > .flags = ADDR_TYPE_RT > > > }, > > > + { > > > + .pa_start = 0x4a00233c, > > > + .pa_end = 0x4a00233f, > > > + .flags = ADDR_TYPE_RT > > > + }, > > > > I do not have any objection/comment here, but I believe this is control > > module address space required for USB module, right? > > I am not sure this is right way of accessing control module space. > > Actually Control Module Access required for drivers is one of the > > blocking issue we have currently. > > > > Also there was some effort put up by 'Konstantine' to convert Control > > module to MFD driver, I haven't seen any further update on it. But it > > would be good to check with him. > > this was an agreement with Benoit since we already lost a couple merge > windows for this patchset. We agreed to wait until -rc4 for SCM driver > and if it wasn't ready, we'd go ahead with this and SCM author would fix > it up on a patch converting users to new SCM driver. Tony, can I get your Acked-by to this patch so I can take it together with the rest of the series ? Thanks ps: I'll apply this to my 'musb' branch which is immutable, so it's safe to merge it into your tree once I apply. -- balbi
Attachment:
signature.asc
Description: Digital signature