RE: [PATCH RESEND v5 3/3] arm/dts: AM33XX: Add D_CAN device tree data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 05, 2012 at 19:16:58, Marc Kleine-Budde wrote:
> On 09/05/2012 01:41 PM, AnilKumar Ch wrote:
> > Add Bosch D_CAN controller device tree data to AM33XX dtsi
> > file by adding d_can device nodes with all the necessary
> > parameters.
> > 
> > Signed-off-by: AnilKumar Ch <anilkumar@xxxxxx>
> > ---
> >  arch/arm/boot/dts/am33xx.dtsi |   18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index bf5f713..ab744d6 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -177,5 +177,23 @@
> >  			compatible = "ti,omap3-wdt";
> >  			ti,hwmods = "wd_timer2";
> >  		};
> > +
> > +		dcan0: d_can@481cc000 {
> > +			compatible = "bosch,d_can";
> 
> On imx/mxs we also add a compatible for the current hardware, this may
> look like this:
> 
> 			compatible = "ti,am33xx-can", "bosch,d_can";
> 
> But I don't know if this is a generic policy or just an imx/mxs thing :)
> 
Marc,

No driver compatible name is ip specific so "ti,am33xx-can" is not
required, I am not seeing any advantage if we add this name.

If there are any changes required for am33xx specific in driver
then we can add "ti,am33xx-can" name in driver otherwise no use.

Thanks
AnilKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux