* Linus Walleij <linus.walleij@xxxxxxxxxx> [120905 05:11]: > On Wed, Sep 5, 2012 at 11:01 AM, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote: > > > When configuring pinmux with pinctrl-single there could be a case when one > > register is used to configure mux for more than one pin. > > In this case the use of pinctrl-single,pins is a bit problematic since we can > > only update the whole register (restricted by the mask). > > In such a situations the pinctrl-single,bits could provide a safe way to handle > > the mux. > > > > pinctrl-single,bits takes three parameters: <reg offset, value, sub-mask> > > The sub mask is used to mask part of the register to make sure we do not change > > bits outside of the scope of this pin. > > > > The first patch in this series is to fix the previous pinctrl-since,pins > > implementation because it was not using the mask on the value which could result > > changed bits outside of the mask. > > This looks sane to me, but I'd like Tony to ACK before I apply it. Cool, this should allow handling cases where some pinctrl devices can have extra aux registers for signal strength etc for some of the pins. Will take a look. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
