On 09/03/2012 07:11 PM, Russell King - ARM Linux wrote: > On Mon, Sep 03, 2012 at 06:13:33PM +0800, Wei Yongjun wrote: >> @@ -130,6 +132,7 @@ static int __init omap2_gpio_dev_init(struct omap_hwmod *oh, void *unused) >> >> pdev = omap_device_build(name, id - 1, oh, pdata, >> sizeof(*pdata), NULL, 0, false); >> + kfree(pdata->regs); >> kfree(pdata); > This one looks wrong. pdata is copied by the internals of > omap_device_build(), which includes the 'regs' pointer, so it should not > be freed after a successful call to omap_device_build(). (It should, > however, be freed after an unsuccessful call.) > > BTW, you want to copy Paul Walmsley with this patch (address in Cc). > > Thanks, I will fix this and send a update version. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
