On Thu, Aug 23, 2012 at 10:38:59PM +0200, Peter Meerwald wrote: > On Mon, 20 Aug 2012, Felipe Balbi wrote: > > > On Mon, Aug 20, 2012 at 04:37:28PM +0530, ABRAHAM, KISHON VIJAY wrote: > > > Hi, > > > > > > On Mon, Aug 20, 2012 at 3:56 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > > > On Mon, Aug 20, 2012 at 03:46:07PM +0530, ABRAHAM, KISHON VIJAY wrote: > > > >> Hi, > > > >> > > > >> On Mon, Aug 20, 2012 at 3:24 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > > >> > On Mon, Aug 20, 2012 at 11:06:34AM +0530, ABRAHAM, KISHON VIJAY wrote: > > > >> >> Hi, > > > >> >> > > > >> >> On Sat, Aug 18, 2012 at 9:34 PM, Peter Meerwald <pmeerw@xxxxxxxxxx> wrote: > > > >> >> > > > > >> >> > 3.6-rc2 fails to compile with > > > >> >> > CONFIG_USB_MUSB_HDRC=m > > > >> >> > CONFIG_USB_MUSB_OMAP2PLUS=m > > > >> >> > > > > >> >> > LD init/built-in.o > > > >> >> > drivers/built-in.o: In function `twl4030_usb_irq': > > > >> >> > /home/pmeerw/linux-3.6-rc2/drivers/usb/otg/twl4030-usb.c:518: undefined reference to `omap_musb_mailbox' > > > >> >> > drivers/built-in.o: In function `twl4030_usb_phy_init': > > > >> >> > /home/pmeerw/linux-3.6-rc2/drivers/usb/otg/twl4030-usb.c:540: undefined reference to `omap_musb_mailbox' > > > >> >> > > > >> >> Having TWL4030_USB as a module will get rid of this. > > > >> >> I'll see how this can be resolved when some modules are *built-in* and > > > >> >> some are made as *modules*. > > > >> > > > > >> > EXPORT_SYMBOL_GPL() should sort that out, right ? > > > >> > > > >> No :-( I already have EXPORT_SYMBOL_GPL() in omap2430.c. > > > > > > > > I see you're missing an "extern" on the function prototype (on the > > > > header). Not sure how modules.dep is generated, but maybe it needs the > > > > "extern" there. Can you check it out ? > > > > > > That isn't helping either. > > > > oh, ok... twl4030-usb is built-in... now that makes sense. Since > > twl4030-usb uses a symbol from omap2430, then it should depend on it, > > otherwise this will always happen. > > so add USB_MUSB_OMAP2PLUS to the depends of TWL4030_USB in > drivers/usb/otg/Kconfig? correct ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
