Re: [PATCH v3] backlight: Add TPS65217 WLED driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi AnilKumar,

thanks for your comments

El Thu, Aug 23, 2012 at 07:53:49AM +0000 AnilKumar, Chimata ha dit:

> This patch should divide into 2 patches, one patch meant for
> MFD changes other for backlight.

will do

> > +struct tps65217_bl {
> > +	struct tps65217 *tps;
> > +	struct device *dev;
> > +	struct backlight_device *bl;
> > +	int on;
> 
> Can you use Boolean here? Change the name as well, something
> like bool is_enabled?

ok

> > +	pdata->fdim = TPS65217_BL_FDIM_200HZ;
> 
> Why 200 by default?

it's the default value in the register after reset

best regards

-- 
Matthias Kaehlcke
Embedded Linux Developer
Amsterdam

                If you don't know where you are going,
               you will probably end up somewhere else
                         (Laurence J. Peter)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux