On Tuesday 24 July 2012, Jon Hunter wrote: > Ok. The thought was that the user would have the following means of > requesting a channel ... > > 1. By name > 2. By a filter parameter (flags) > 3. By name and a filter parameter > > So we would have the following APIs ... > > struct dma_chan > *of_dma_request_channel(struct device_node *node, unsigned int flags); > struct dma_chan > *of_dma_request_named channel(struct device_node *node, char *name, > unsigned int flags); > > In both of these the filter parameter flags is optional. > > Let me know your thoughts on this. I definitely like this version. I was thinking of a different variant where we have separate functions for each flag value, but I think yours is actually better. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html