On Fri, Jul 20, 2012 at 10:09:43, Nayak, Rajendra wrote: > On Thursday 19 July 2012 05:38 PM, Vaibhav Bedia wrote: > > As per the comment in omap2_common_late_init() looks like the > > original intent of the DT check was to treat only the PMIC > > and SR initialization differently. Recent changes to consolidate > > the suspend-resume code across OMAP3/4 resulted into the > > registration of suspend ops also being dependent on the check > > for DT blob. Since the suspend-resume operation should not > > really be dependent on the usage of DT remove this dependency > > by wrapping the PMIC and SR init under the DT check. > > So I am guessing you also tested suspend/resume on your hardware > with this patch, when booting with a DT blob, and it passed. > I am getting there ;) I am in the process of getting a real suspend/resume functional. As part of this I was just flow flushing the whole suspend process in the mainline kernel by putting in a dummy implementation for the .enter op and found that this change was needed. Regards, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html