Hi one trivial comment On Mon, 11 Jun 2012, Tero Kristo wrote: > diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h > index 46ab9d9..8d7de4f 100644 > --- a/arch/arm/mach-omap2/pm.h > +++ b/arch/arm/mach-omap2/pm.h > @@ -88,6 +88,8 @@ extern void enable_omap3630_toggle_l2_on_restore(void); > static inline void enable_omap3630_toggle_l2_on_restore(void) { } > #endif /* defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP3) */ > > +#define PM_OMAP4_ROM_SMP_BOOT_ERRATUM_xxx (1 << 0) "xxx" isn't unique, nor is it descriptive :-) Looking at the mail threads on this one, it sounds like there may not be a public erratum number associated with this. If there is, the 'xxx' should be replaced with the number. If there isn't, then it would be good to make up something short, like "GICD" to replace the "xxx". - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html